-
Notifications
You must be signed in to change notification settings - Fork 284
Linux portduino arch #1137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Linux portduino arch #1137
Conversation
|
Nice! I look forward to this! |
| #if defined(NRF52_PLATFORM) | ||
| return _fs->open(fname, FILE_O_WRITE); | ||
| #elif defined(RP2040_PLATFORM) | ||
| #elif defined(RP2040_PLATFORM) || defined(ARCH_PORTDUINO) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is it maybe time to move fs access either to the board abstraction, or to its own abstraction so we can avoid all of the platform checks in the main code? @ripplebiz ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also have a look at this one: https://github.com/meshcore-dev/MeshCore/pull/1137/files/53d53fbb34f578b1bbcdfa86a3b4f8d9d8b3eb16#diff-37ca67c35b6bde867acedc3db6bb9eab58c5533e69de348a1688383af4f1645fR67
I added config to linux board. It would be useful to have config in any board. Currently examples are still using defines for node name, position, etc.
I didn't touch it because it would be rude to alter so many files in the first PR ;)
examples/simple_repeater/MyMesh.cpp
Outdated
|
|
||
| void MyMesh::dumpLogFile() { | ||
| #if defined(RP2040_PLATFORM) | ||
| #if defined(RP2040_PLATFORM) || defined(ARCH_PORTDUINO) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: can we name this PORTDUINO_PLATFORM to be more in line with the other defines?
This PR allow to run MC on rpi zero 2w, running debian 13.
See https://github.com/ggodlewski/MeshCore/blob/linux/variants/linux/README.md for instruction and remarks.
I have RPI with POW + 2 * SX1262 running both MC and MT at the same time.
Resolves: #619